nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Accomodation equality should also consider the place #394

Open nus-se-bot opened 3 years ago

nus-se-bot commented 3 years ago

Currently, 2 accomodations are considered duplicates if they share the same name, start date and end date. However, I think that it would make more sense for accomodation to consider the place in equality as well (eg. 2 accomodations with same name, start date and end date but different place are not duplicates), because for example, a hotel chain might have hotels with the same name in 2 different locations.


[original: nus-cs2103-AY2021S1/pe-interim#351]

jiaweiteo commented 3 years ago

Team's Response

We acknowledge that this may be a feature flaw for our application, given that hotel chain can have 2 different hotels of the same name but at different locations (e.g. Holiday Inn).

However, we feel that this bug should be considered as low severity as it is rare and unlikely to affect normal operations of the product and it only cause a minor inconvenience. Furthermore, users can add unique names to the accommodation to differentiate the different accommodation. (e.g Holiday Inn Singapore Atrium and Holiday Inn Express Singapore Clarke Quay), and with the specific address as the location.

Duplicate status (if any):

--