search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Missing Merge node in activity diagram #4571

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

First branch node missing a corresponding merge node Screenshot 2020-11-13 at 5.38.13 PM.png

[original: nus-cs2103-AY2021S1/pe-interim#4386]

chan-j-d commented 3 years ago

Team's Response

Every branch node does not necessarily need a merge node. It is not a bug.

merge node.png Image is taken from CS2103/T Luminus quiz 9 part 1 where this diagram is a valid diagram for the description and it only has one branch node with no merge node. Thus, merge node is not a requirement.

This diagram makes use of the ability to have multiple end nodes in an activity diagram (which is allowed based on the discussion here). As such, it prematurely terminates one of the branches from the branch node.

Merge nodes are useful when we want to explicitly merge alternate activity branches back into the same path. This is not the case.

Duplicate status (if any):

--