search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

able to add invalid url in add patient/edit patient #5463

Open nus-pe-bot opened 4 years ago

nus-pe-bot commented 4 years ago

system: catalina

description: while the UG states that only certain urls are valid, I was able to enter anything I liked.

expected and actual result: expected error message, instead patient was added. This issue occurs for edit patient as well.

step to reproduce:

  1. type in parameters as required.
  2. instead of "www." type any of the following headers in the screenshots, ie. "www," "ww." "http"
  3. for top level domain, type anything that is longer than 6 alphabets long or not an alphabet.

Screen Shot 2020-11-13 at 5.05.13 PM.png

Screen Shot 2020-11-13 at 5.00.38 PM.png

Screen Shot 2020-11-13 at 4.23.01 PM.png

Screen Shot 2020-11-13 at 5.01.51 PM.png

Screen Shot 2020-11-13 at 5.04.37 PM.png

[original: nus-cs2103-AY2021S1/pe-interim#5386]

Cedo8 commented 4 years ago

Team's Response

We have indicated our definition of a valid url in the UG clearly and we wanted to relax the requirements of a valid URL to account for local host (which may have unusual namings).

Duplicate status (if any):

--