nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Recall command does not work on second time #5915

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

When I try the command recall push up after an invalid command, Calo shows me no matched exercise.

When I try recall push up for the first time, all is good, I see the entry found.

image.png

After that I try an incorrect input, recall push u , and it shows me no entries, as expected.

image.png

However after that, when I try a recall push up again and click enter, I still dont see any entry.

image.png

Steps to reproduce: Use the commands in the specified order:

  1. recall push up
  2. recall push u
  3. recall push up

Expected: For 1st command, I see 1 entry. For 2nd command, I see 0 entries. For 3rd command, I see 1 entry.

Actual: For 1st command, I see 1 entry. For 2nd command, I see 0 entries. For 3rd command, I see 0 entry.


[original: nus-cs2103-AY2021S1/pe-interim#5897]

Liu-2001 commented 3 years ago

Team's Response

Hi! Actually, recall is to search for the most recent exercise with the specified name in the current exercise list. By current exercise list I mean the list shown in GUI. recall seems not to work after using find or recall command because the current exercise list has been changed (filtered by find or recall) and is different from the whole exercise list. I did fail to mention this in UG. Therefore, I think this should be labeled as a documentation issue. Also, I think the severity level should be medium instead of high because users can proceed to use our product by using list first and then using recall if they wish to recall in the range of the whole exercise list. This falw does not make our product almost unusable for users (the definition of severity.high in admin info).

image.png

I marked another issue (#5927 recall after find does not yield intended result) as a duplicate of this issue because they are caused by the same flaw (i.e. I didn't mention in UG that recall only search for exercise in the current list) in nature.

Duplicate status (if any):

--