nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Macro logic diagram problem #5954

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


I think the two loops should be combined? Since only after first loop the command object parsed is then used for second loop Also the condition being "for each macro line" may be could be rephrased Screenshot 2020-11-13 at 5.37.28 PM.png


[original: nus-cs2103-AY2021S1/pe-interim#5940]

JoeyChenSmart commented 3 years ago

Team's Response

The two different loops are intentional here. In the code there are actually 2 different loops, the first executes the parsing all at once, then the second executes the commands one by one. This is so we can catch any parse errors in the first loop, before running the second loop.

The paragraph right above describes these two seperate steps:

image.png

Duplicate status (if any):

--