search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Logic Diagram PrimitiveCommandParser should be destroyed near the end of graph #5955

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Screenshot 2020-11-13 at 5.37.28 PM.png PrimitiveCommandParser should be destroyed with "X" after it is used

[original: nus-cs2103-AY2021S1/pe-interim#5941]

chewypiano commented 3 years ago

Team's Response

Thank you for the bug report.

Firstly, we will classify this "issue" as VeryLow instead of Medium. As explained below (below the image), this is an optional addition to a sequence diagram and is thus purely cosmetic.

image.png

Secondly, we will also kindly reject this as a legitimate bug. As shown in the image below, the textbook specifies that "object deletion is not that important in languages such as Java" and that "you can still show" it, which imply that object deletion is not a necessary inclusion. Since it is optional and not the focus of this diagram, we reject this as a bug.

Screenshot 2020-11-14 at 4.56.59 PM.png

Duplicate status (if any):

--