search

nus-cs2103-AY2021S1 / pe-dev-response

0 stars 0 forks source link

Non-specific error messages #6006

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

When adding a new contact with the phone number in this format +65 92345671, it shows the following error message.

image.png

The UG mentions the following The country code +65 is also accepted at the start of PHONE_NUMBER, however it did not specify what the correct format example is, nor did the error message in the app. It took me awhile to realise there shouldnt be any spaces between the country code and the phone number, as such: +6592345671

[original: nus-cs2103-AY2021S1/pe-interim#5998]

joshualiangxy commented 3 years ago

Team's Response

image.png

The UG states that PHONE_NUMBER is a valid Singaporean number that is 8 digits long, starting with 6, 8, 9, so there are no spaces in PHONE_NUMBER.

It then states that +65 can be accepted in front of PHONE_NUMBER, so it is expected that +65 is added directly in front of PHONE_NUMBER.

If PHONE_NUMBER accepted numbers in the format of 9123 4567, it can be more understandable that users might believe that there can be a space between +65 and PHONE_NUMBER, but there is no space, and the users can expect this to be consistent.

Duplicate status (if any):

--