search

nus-cs2103-AY2021S2 / forum

10 stars 0 forks source link

Typo in class name JsonSerializableAddressBookStorage in StorageClassDiagram #273

Closed candyhy closed 3 years ago

candyhy commented 3 years ago

Class JsonSerializableAddressBookStorage does not exist. I believe it should be JsonSerializableAddressBook instead

Screenshot 2021-03-30 at 2 12 36 AM
w2vgd commented 3 years ago

Yeahh I realized that in addition to this, there is also a typo in JsonSerializablePerson. It should have been JsonAdaptedPerson instead.

image

damithc commented 3 years ago

Thanks @candyhy and @w2vgd for reporting this. I've reported it at https://github.com/se-edu/addressbook-level3/issues/86

damithc commented 3 years ago

Fixed in https://github.com/nus-cs2103-AY2021S2/tp/commit/f741ba434f77b3dd25bc6a84c2cd9ebd4b30df3a