search

nus-cs2103-AY2021S2 / forum

10 stars 0 forks source link

practice paper 1 question 8 #347

Closed prerthan99 closed 3 years ago

prerthan99 commented 3 years ago

Screenshot 2021-04-22 at 3 16 03 PM

why is "reading" not considered a 'magic value'. shouldn't we name it something like waitingMessage = "reading" or something? thanks in advance

tlylt commented 3 years ago

Hello, perhaps this question is focusing on the coding standard as in coding style, instead of other aspects of code quality (E.g magic literals).

prerthan99 commented 3 years ago

ic, thank you. I think I conflated the 2