Discussion of Past Year Paper Part 2

nus-cs2103-AY2021S2 / forum

10 stars 0 forks source link

Discussion of Past Year Paper Part 2 #362

Open ZhangAnli opened 3 years ago

ZhangAnli commented 3 years ago

Hello would just like to check my answers with you guys for this question's sequence diagram as well :)

Screenshot 2021-04-23 at 8 20 13 PM

glatiuden commented 3 years ago

Hi! It looks fine but these are some things I have noticed but I'm not 100% if they are correct, please do correct me if I am wrong!

new keywords should be omitted in Sequence Diagram
Person("Adam", "friend") and addPerson(p) should be within the loop box itself, otherwise I think it might be misinterpreted as the methods are only executed once?

ZhangAnli commented 3 years ago

Ok I see, thanks!

kouyk commented 3 years ago

For this diagram, I think the constructor activation bar of Person can be extended a little longer, such that it is activated longer than the constructor of Tag. The Tag might not need to be named. Since the Person object is named, it would be better if it's also returned as well, especially since it is used by the external caller as an argument.

damithc commented 3 years ago

Also, this exact question was discussed during tutorial 8. You may want to watch the week 8 tutorial recording.