search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Duplicates allowed occasionally when adding venue names #1011

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Referring to 8 and 9 and my command, not sure why my command is rejected (add n/Residence a/no and add n/residence a/no do not work), and yet I could add 8 and 9 with no problem. I think that duplicate detection is inconsistent, and is also not specified in the documentation.

Screenshot 2021-04-16 at 14.28.09.png Screenshot 2021-04-16 at 14.28.52.png

[original: nus-cs2103-AY2021S2/pe-interim#1011] [original labels: severity.Medium type.FunctionalityBug]

whatthelump commented 3 years ago

Team's Response

Duplicate residence names are not allowed; the reasoning for this should be intuitive given that a user would not want to confuse themselves by having two entries with exactly the same name displayed on the app, which explains the rejection of those add commands.

However, we do not restrict users from setting similar residence names (e.g. as shown in the example, different capitalisation used) as they could still differentiate the residences visually on the app. Therefore 'Residence' and 'residence' are not detected as duplicates.

Duplicate status (if any):

--