search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

add command bug: people with different name but same other fields are allowed #127

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

steps to produce:

  1. add -n John Doe -p 98765432 -e johnd@example.com -c Google -j Software Engineer -a 311, Clementi Ave 2, #02-25 -r University friend -t friends -t owesMoney

  2. add -n John Do -p 98765432 -e johnd@example.com -c Google -j Software Engineer -a 311, Clementi Ave 2, #02-25 -r University friend -t friends -t owesMoney

expected: warning saying, the two persons have the same phone number email address etc

actual: no warning is shown

Screenshot 2021-04-16 at 2.22.48 PM.png

[original: nus-cs2103-AY2021S2/pe-interim#127] [original labels: severity.Medium type.FunctionalityBug]

darkdestry-t commented 3 years ago

Team's Response

This issue is not considered an issue by the team. Our application is targeted towards business contact management.

This means that multiple employees can share the same office numbers if the office only has one landline, and the call would then be forwarded internally.

Similarly, the address and email address of different persons from the same company can be the same company address and email address (especially when the company is small and share the same email address for public communication).

This "uniqueness" issue is a complex issue and enforcing it would mean restricting use cases like the one mentioned above. This is not in the scope of this module and thus marked as NotInScope.

Duplicate status (if any):

--