search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Budget constraints not enforced after setting bg #2482

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Before set-bg, as expected: image.png

command used: set-bg 1 add-fr d/d a/10

image.png

Before setting bg, users cannot add fr over budget. But this is possible after setting a lower bg. Happens for edit as well.

[original: nus-cs2103-AY2021S2/pe-interim#2482] [original labels: severity.High type.FunctionalityBug]

natosy commented 3 years ago

Team's Response

Hi, our team will be rejecting the error due to the fact that it was done in part II of the bug reporting phase, and also because the issue stated is not a bug.

Regardless, we will still give you an explanation of the behaviour that you have seen above. The "error" that you are stating is an intended feature of our application. In your first screenshot, you are attempting to add a financial record with the amount of $999,999. As seen from the screenshot, your current expenditure is $73.50. The addition of the amount stated would then lead to an overall amount of $1,000,072.50. Our application rejects any addition of financial records which causes the expenditure to exceed the amount of $1,000,000, as clearly seen from the error message starting with Action denied! Your current action will cause....

In your second screenshot, you have set the budget to be $1 and thereafter added another financial record of the amount $10. There is no issue with the behaviour in the addition of financial records as it does not exceed the maximum amount of $1,000,000. Our application allows for users to add financial records which result in spending above their budget, as long as it does not exceed the hard limit of $1,000,000.

If you would like to attempt your first screenshot again, you may attempt the function add-fr d/d a/1001. You will also see that it is added to the list even though it exceeds the month's budget, as it does not violate our app's restrictions. Similarly, if you attempt the command add-fr d/d a/999999 after setting the budget to 1 as seen in your second screenshot, this addition would have been rejected as well, due to the same reason as the first picture.

Duplicate status (if any):

--