nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Unexpected way of sorting #2593

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Current behavior: Sort sorts by urgency tags and lastly date. So a delivery with earlier date but no "urgent" tag will be sorted later than a delivery tagged with "urgent" but of a later date.

Explanation for bug: Date is expected to be the date of delivery. Hence I don't think that the "urgent" tag should have a higher priority than the date of delivery.

In a way the purpose of an "urgent" tag and a date of delivery are similar and hence contradict one another.

Suggestion: I think that having an "urgent" tag will be more useful when comparing deliveries in a day. If a delivery for that day is labelled as "urgent", as compared to other deliveries for that day, a delivery man would then deliver the "urgent" things first.

Perhaps you can prioritise date before the "urgent" tag. And only use the "urgent" tag to sort when looking at deliveries of the same day.

image.png


[original: nus-cs2103-AY2021S2/pe-interim#2593] [original labels: severity.Medium type.FunctionalityBug]

cheunggalen commented 3 years ago

Team's Response

The urgent tag is meant to override everything else in terms of priority. A driver may decide to tag a delivery entry as urgent due to reasons such as the sudden request of the customer to receive the delivery asap. The driver could also simply decide to prioritise the delivery entry by tagging it as urgent despite its late delivery date, perhaps to complete and get a difficult delivery out of the way first, or prioritise delivering to a friend.

Duplicate status (if any):

--