search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Duplicate identical appointments can be added #2891

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Appointments with the exact same date and time are not recognized as duplicates, and show up as multiple instances of the appointment. No error message is thrown to stop the user from adding a duplicate.

Steps to reproduce:

  1. appt 1 d/24051800
  2. appt 1 d/24051800
  3. appt 1 d/24051800

Below is the screenshot:

Screenshot 2021-04-16 at 2.27.08 PM.png

[original: nus-cs2103-AY2021S2/pe-interim#2891] [original labels: severity.Medium type.FunctionalityBug]

nicholasnge commented 3 years ago

Team's Response

We appreciate the feedback and think this is a good feature to add, but we dont see this as a bug since we did not claim to check for duplicates in the appointment.

In fact, our team has considered many things to check for during the creation of an appointment, such as duplicates as you have mentioned, unlikely timings for appointments (think 12am on a saturday morning), etc. but decided to only implement the most detrimental mistake during appointment creation which is adding a date that is already past. (we had other more important features to implement)

We dont really view this as a bug and it is out of our scope

Duplicate status (if any):

--