darkdestry-t
commented
3 years ago Team's Response
The uniqueness of a person by their name is a system design in AB3 that our application has adapted. The uniqueness of a person can be subjective and there are many ways to decide that, be it with phone number, address, email address, etc. Our team decided to keep it simple and adapt AB3 implementation and check uniqueness by name.
Although the issue you raised on the uniqueness of a person is valid, under normal circumstances, this would be taken as a feature request for A-Bash Book. This uniqueness issue is a complex issue not in the scope of this module and thus marked as NotInScope.
There are also other things to note when it comes to the uniqueness of a person:
- Name and phone number are not enough to identify if two persons are unique. Two persons with the same name from the same company can have the same office number that they are contactable at.
- This issue can be easily circumvented by adding a nickname like how you would identify 2 persons in real life that has the same name.
Duplicate status (if any):
--
Command Sequences: add -n John Doe -p 98765432 -e johnd@example.com -c Google -j Software Engineer -a 311, Clementi Ave 2, #02-25 -r University friend -t friends -t owesMoney add -n John Doe -p 12345678 -e johnd@anotherexample.com -c Amazon -j Algorithm Engineer -a another place
Explaination: Though it's the feature flaw inherited from AB3, duplicate name is very usual nowadays. Would you think it's better to prevent inputing the same person by double checking the value of phone number? I think it's more reasonable.
Screenshot:
[original: nus-cs2103-AY2021S2/pe-interim#3025] [original labels: severity.Low type.FeatureFlaw]