nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

App: Index overflow leading to wrong error message in the done/notDone/edit/deleteTag commands #3079

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Integer overflow causes app's done command to give a wrong error message.

image.png

image.png


[original: nus-cs2103-AY2021S2/pe-interim#3079] [original labels: severity.Medium type.FunctionalityBug]

yhtMinceraft1010X commented 3 years ago

Team's Response

Thank you for your report.

The integers are parsed in this manner: 1) Use of built-in Java methods to attempt to parse the index (given as string) to an integer. Reference: parseInt() method

2) Check that the integer is unsigned non-zero.

For very large positive integers resulting in overflows, step 1) fails, which is a limitation of Java itself.

Duplicate status (if any):

--