search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Favorite Star Sign is Hard to See #3134

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

The favorite sign blends in with the background and is too small.

image.png

[original: nus-cs2103-AY2021S2/pe-interim#3134] [original labels: severity.Low type.FeatureFlaw]

Winniehyx commented 3 years ago

Team's Response

Dear responder, thank you for highlighting this issue. However, this is a design decision that I, as an implementer has decided on. I decided on the star icon as it was the most visible out of all the stars that are in icon. I believe that you are using the app in the minimized mode which caused the star symbol to be smaller than what is expected. In addition to the star symbol beside the name, there is a result display bar in case you can't see which tutor you have just added as a favourite. Also, we have also implemented a list_favourites in case you are unable to see clearly the star symbol beside the name. The User Guide has also said how the favourite indicator looks like on mac which I think you are using.

image.png

This is how the favourite indicator looks like on windows which is what I am using.

image.png

This is a javaFx limitation as it is how the javaFx renders the star character as different machine has different settings. It is a NFR rather than a bug.

Duplicate status (if any):

--