search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Date not accepted despite following the format #511

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

add n/AAA p/1234 e/EMAIL@a a/abcd b/17-04-0000 date follows the format and error but is still not valid image.png

[original: nus-cs2103-AY2021S2/pe-interim#511] [original labels: severity.Low type.FunctionalityBug]

ivantjh commented 3 years ago

Team's Response

Hi there, thanks for the feedback. We have decided not to accept this issue as it is a class behaviour from java’s LocalDate class.

The date 17-04-0000 is actually invalid as such dates do not exist. Refer to https://en.wikipedia.org/wiki/Anno_Domini#No_year_zero:_start_and_end_of_a_century

LocalDate only throws a single error if there is a problem with parsing. Hence, it is too tedious and difficult to manually check each type of error arising from the parsing of date strings by ourselves. Examples of errors are wrong date format (YYYY-MM-DD) or invalid years (e.g 0000) Therefore, this bug report is out of scope for v1.4.

Refer to #507 and #2323 at here for more info

Duplicate status (if any):

Duplicate of #2323