search

nus-cs2103-AY2021S2 / pe-dev-response

0 stars 0 forks source link

Free-time does not list complete free time slots for last minute #711

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

Edge Case: There is still 1 minute left in the day 2022-02-26 between 23:59 and 00:00 in the next day. UG does not explicitly state what counts in a day but I believe that last minute still belongs to the 26th!

Steps to replicate

  1. add_event n/CS2103 meeting sd/2022-02-26 st/15:00 ed/2022-02-26 et/23:59
  2. free_time 2022-02-26

image.png

Preferred Outcome Message

Found free time slots on 2022-02-26: 
00:00 to 14:59
23:59 to 00:00

[original: nus-cs2103-AY2021S2/pe-interim#711] [original labels: severity.VeryLow type.FeatureFlaw]

ddanelynn commented 3 years ago

Team's Response

As time is specified to minute not second, we do not count the last minute in. This is the intended behaviour as if we count the last minute in, there will be an overlap in time for free and busy.

Duplicate status (if any):

--