search

nus-cs2103-AY2122S1 / forum

18 stars 2 forks source link

Noticed a very small typo in the textbook #446

Open kevinchua6 opened 3 years ago

kevinchua6 commented 3 years ago

image

I noticed notifyUIs doesn't follow the Java coding standards (below) in this section. Should probably be notifyUis instead

image

Sorry, I'm still in the pe mood and this has been bugging me :p

kaixin-hc commented 3 years ago

On the topic of minor typos, I also found some other minor typos 😅... just going to jump on this thread so as not to clutter the forum.

Screenshot 2021-10-26 at 12 10 06 AM
Screenshot 2021-09-28 at 10 05 11 PM
Screenshot 2021-11-15 at 5 08 01 PM
Screenshot 2021-09-28 at 10 11 47 PM

..

fans2619 commented 3 years ago

I think the underline thing is intentional, not really underline, just using larger font to highlight

damithc commented 3 years ago

Thanks guys, keep them coming. Every bug report helps.

I think the underline thing is intentional, not really underline, just using larger font to highlight

It's bug. MarkBind recently changed the syntax it uses for underlines. The previous syntax ++text++ is now used to making the text bigger. These are places where I overlooked when migrated to the new syntax.

fans2619 commented 3 years ago

Oh I see!

damithc commented 3 years ago

I noticed notifyUIs doesn't follow the Java coding standards (below) in this section. Should probably be notifyUis instead

Good catch. I think I made an exception in that case because notifyUis is harder to read than notifyUIs (due to the additional lower case s).

damithc commented 3 years ago
Screenshot 2021-10-26 at 12 10 06 AM

@kaixin-hc where did you find this? This was fixed sometime back in the module website.

Screenshot 2021-09-28 at 10 05 11 PM

Good catch. Will fix.

Screenshot 2021-11-15 at 5 08 01 PM

Good catch. Will fix.

Screenshot 2021-09-28 at 10 11 47 PM

Good catch. Will fix.

kaixin-hc commented 3 years ago

@kaixin-hc where did you find this? This was fixed sometime back in the module website. I took these screenshots over the course of the semester, and didn't think to check that they still worked with the website. I see that it is fixed on the module website now!

damithc commented 3 years ago

I took these screenshots over the course of the semester

Nice. 👍 Yes, it was fixed in the middle of the semester.

trxe commented 3 years ago

Adding to the thread some other small typos:

MSS

I believe there should be a space here? i.e. ". ["

Typo bug

kaixin-hc commented 3 years ago
grammar

Grammatical issues where highlighted + I feel it would be clearer to put the quote in quotation marks, rather than in italics.

AllardQuek commented 3 years ago

Good catch @kaixin-hc! I don't think "tasks that needs" is a grammatical error though, because it is the list of tasks that needs the user's attention.

image

kaixin-hc commented 2 years ago

Oh, I interpreted it as referring to the tasks by proximity, and I expected what needed the attention were the tasks, not the list itself. Especially as the next sentence uses a plural pronoun for what needs to be paid attention to (if the intent was to focus on the list, maybe the plural pronoun shouldn't be used in the next sentence).

AllardQuek commented 2 years ago

Yup, makes sense!

damithc commented 2 years ago

Thanks all. Will fix in the next version.