search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

If adding a person of the same name to the Interest Group, application is unable to differentiate between them #1005

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

When a person clears a person, the person still exists in the event list.

This causes ambiguity if users add a person of the same name, without the same tags to the IG. The person cannot attend the event even if they are different people but with the same name

Screenshot from 2021-11-12 16-36-23.png Screenshot from 2021-11-12 16-36-44.png Screenshot from 2021-11-12 16-38-26.png

[original: nus-cs2103-AY2122S1/pe-interim#980] [original labels: severity.Low type.FunctionalityBug]

yongxiangng commented 3 years ago

Team's Response

Downgraded linked issues to be veryLow, because this is just a visual cue. There is no bug here, and the decision made here is to show the events as a static one, rather than a dynamic one. Hence, a cosmetic issue.

This issue is linked to the other issues. Essentially, it has to do with the event being a static snapshot.

If tester is interested, tester could read the other linked/duplicate issues to see the pros and cons of using events as a static snapshot rather than a dynamic one which updates.

However, this issue is slightly different as this use case should not happen in normal course of usage. When an event is created, and a person is added to the event, you can be sure that there is no duplicate person in the application. However, if the user chooses to delete the member, then add a member of the same name into the application, but different state, and tries to take their attendance in the same event, this is a misuse and it is right for the application to stop this input to prevent duplicate name (If we allowed duplicate names in the event, then someone is going to end up filing the report for the other side of the argument, please be reasonable). The reason why I say it is a misuse, is because this scenario only happens if the user tries to add a member to a past event (How likely is it for you to have first John to attend an event, then first John leaves the IG, second John joins the IG on the same day and joins the same event on the same day?), which should not happen as the attendance taking should happen only on the same day (we won't be trying to add someone to an event we created a few days ago). This is not a bug, and the user should definitely have expected this to happen (This is not something where the user will go HUH??? :shocked: ). I understand where the tester is coming from, but this case is really too obscure and extremely extremely unlikely to happen.

tldr; not a bug and we have made it clear to the users in the UG. if the argument is for the events to be dynamically updated, there are pros and cons to both sides and it's just a design decision we have made and should not be considered a feature flaw since there are going to be flaws for either decision we make

Duplicate status (if any):

--