search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

DG: Duplicate activity diagrams #1369

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

image.png I'm unsure what two diagrams of almost exactly the same behaviour is for. Can just state that it is the same as add. Wastes space.

[original: nus-cs2103-AY2122S1/pe-interim#1422] [original labels: severity.VeryLow type.DocumentationBug]

BenjaminLHR commented 2 years ago

Team's Response

Hi, there are actually noticeable differences in the activity diagrams. For adding a game entry, a GameEntry object is created first and then it is encapsulated within AddCommand. However, for EditCommand, the creation of the GameEntry happens during the execution of the Command. Another difference is that for editing, a new copy of GameEntry replaces the old copy. This is not the behaviour for adding a game entry.

Duplicate status (if any):

--