search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection: two person with slightly different name but same arttibutes are not detected. #1672

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Steps to reproduce: type add n/John Doe p/98765432 e/johnd@example.com g/4.50 i/NTU c/Computer Science y/06/2025 j/Software Engineer a/INTERVIEWED s/Java s/Python and then type add n/John Doe NTU p/98765432 e/johnd@example.com g/4.50 i/NTU c/Computer Science y/06/2025 j/Software Engineer a/INTERVIEWED s/Java s/Python

Expected: since these two persons have exactly same phone, same email, etc, the software should detect this kind of duplication and give warning.

Actual: These two persons are added to the list.

Screenshots:

image.png

[original: nus-cs2103-AY2122S1/pe-interim#1729] [original labels: severity.Low type.FeatureFlaw]

jackgugz commented 2 years ago

Team's Response

Since applicants can share the same email address(such as in the same organisation) and share the same phone number (office/home phone), we decided not to use other fields to verify duplicate applicants.

Duplicate status (if any):

--