search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

[Bug] Editing the name of a link so that there are duplicate links #1769

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Expected Result: The name of a link cannot be edited as the same name of another existing link.

Actual Result: The name of a link can be edited as the same name of another existing link.

Step to Reproduce:

  1. Add a link named Google
  2. Add another link named Yahoo
  3. Edit the name of the first link to Yahoo as well
  4. Edit successfully, there are duplicate links in the database

image.png

[original: nus-cs2103-AY2122S1/pe-interim#1740] [original labels: type.FeatureFlaw severity.Medium]

Tianqi-Zhu commented 2 years ago

Team's Response

As stated in the user guide, a link is considered as a duplicate ONLY if it has the same Name AND Address as another link.

image.png

Also, this cannot be considered a Feature flaw as it allows the user greater flexibility in creating/editing their links rather than restricting them to always have links with unique names. For example, a user may want to create 2 links with the name "CS2103t module information" and one goes to the module website while the other goes to the LumiNUS website.

Duplicate status (if any):

--