search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Reminder reminds after 10 seconds of every new command, not just reminder updated for a friend #2130

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

In the UG, it is stated:

image.png

What I assume this means is that upon updating the notification status of any person (i.e. switching on a reminder or switching off a reminder), it will give me a reminder in 10 seconds after that.

However, what I notice is that after ANY command, such as adding a new person in who's birthday is not today, or editing another persons birthday, it will also trigger the reminder

Steps to reproduce:

  1. Input add n/Johnathan Doenut e/lol@gmail.com p/123123123 b/2021-11-12 r/on
  2. After 10 seconds, reminder pops up wishing him happy birthday, this is expected
  3. Input edit 10 n/editsomeoneelse (where 10 is the index of someone who is not Johnathan Doenut)
  4. Even though I am not editing any persons reminder updated (which i presume is r/on or off), after 10 seconds, the reminder will pop up for Johnathan Doenut

This can be quite annoying for users as the pop up will keep popping up after every command after 10 seconds, which would possibly cause me to disable to notification, and forget about it next year, which defeats its purpose.

[original: nus-cs2103-AY2122S1/pe-interim#2188] [original labels: type.FunctionalityBug severity.Medium]

pss-coder commented 2 years ago

Team's Response

every Commands makes an update to the list.

Duplicate status (if any):

Duplicate of #5552