search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

I can effectively have duplicates if I simply change the language, but the foreign phrase and english phrase are kept the same. #2891

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Steps to reproduce:

  1. Do clear to make sure that there are no flashcards in the application.
  2. Do the following command: add l/Chinese e/Good Night f/晚安
  3. Do the following command: add l/English e/Good Night f/晚安

Then you should see the following:

image.png

This is an issue because when I start the slideshow, the two flashcards are exactly the same, and are not affected by the l/ fields being different. So I have effectively created a duplicate here.

I know that your user guide states the definition of what you guys call a duplicate:

image.png

But I think some users would have issues with this, especially if they have a typo like shown below:

image.png

[original: nus-cs2103-AY2122S1/pe-interim#2947] [original labels: type.FeatureFlaw severity.Medium]

sharmainec commented 2 years ago

Team's Response

We have already clearly stated what is defined to be a duplicate flashcard (same LANGUAGE, ENGLISH_PHRASE, and FOREIGN_PHRASE) in our UG.

Also, some languages have the same ENGLISH_PHRASE and FOREIGN_PHRASE. E.g. the number 5 is lima in both Malay and Filipino. Therefore, we cannot assume that these flashcards are the same simply because they have the same ENGLISH_PHRASE and FOREIGN_PHRASE

Furthermore, the example given above is a user error and not a fault in our app.

Duplicate status (if any):

--