nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Same Telegram handle and Github username not allowed for `add ` command but same phone number allowed. #37

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

The restriction placed for same telegram handle and same github username makes sense, but I feel that this restriction should be placed on phone numbers as well (even though it's an optional), since there should not be duplicate people with the same phone number.

Screenshot 2021-11-12 at 4.40.25 PM.png

Screenshot 2021-11-12 at 4.40.35 PM.png


[original: nus-cs2103-AY2122S1/pe-interim#35] [original labels: severity.Low type.FeatureFlaw]

CheongYeeMing commented 2 years ago

Team's Response

Users are only considered unique by GitHub and Telegram. Two contacts can share the same phone number although it is unlikely. For example, if they are from the same family and give their home phone number.

Duplicate status (if any):

--