nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Irrelevant error message given when contact name is too long #3769

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

image.png

Steps to reproduce: Type in the following command:

touch -n verylongnameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee -p 98765432 -e johnd@example.com -a John street, block123, #01-01

Expected: A proper error message explaining that the contact name is too long, and the constraint needed (over 50 characters)

Actual: An irrelevant error message stating that our friend's name is too long and we should unfriend them

This is clearly an attempt at humor by the devs, but it fails at its function as an error message to provide insight to a user as to why their command has failed.


[original: nus-cs2103-AY2122S1/pe-interim#3727] [original labels: severity.Low type.FeatureFlaw]

sebbycake commented 2 years ago

Team's Response

too long is an indication of why the command failed, so this serves as the insight that you are looking for. Furthermore, it was mentioned explicitly in the UG that the maximum length of the name is 70 characters.

Duplicate status (if any):

--