search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Adding/Editing new CCA to match the CCA in reminder causes the reminders and CCA to be linked but not deleted when new CCA is deleted #4567

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Continuing from the feature flaw I proposed where the reminders are not deleted along with the CCA, if new CCA is added with the same name or later edit to fit the ones in the existing reminders, the reminders are now 'linked' with that CCA (which is good) but when the CCA is deleted the reminders are still there.

Consider the following scenario:

New CCA is added with reminders still remaining after deletion: Screen Shot 2564-11-12 at 16.45.22.png

The name of CCA is changed to that of the CCAs that exist in reminder: Screen Shot 2564-11-12 at 16.45.53.png

Every CCAs are deleted: The name of the CCA is changed so do the ones in the reminder despite them being conceptually^ different CCA by the time the CCA is added: Screen Shot 2564-11-12 at 16.47.37.png

Screen Shot 2564-11-12 at 16.54.57.png

^conceptually as in it was not intended to be the same CCA in the first place but the name is changed to be the same intentionally to create the bug

PS: surprisingly the other reminder is now actually deleted with the CCA being deleted but not for the ones that actually still remain in the reminder, it is surprisingly still there. The team has made effort to deal with this bug before but further investigation is required after the PE since the bug still remains in my case.

[original: nus-cs2103-AY2122S1/pe-interim#4635] [original labels: type.FunctionalityBug severity.High]

justintanyf commented 2 years ago

Team's Response

As "Deleting CCA does not delete the reminder(s) associated with that CCA #4566" cannot be reproduced, my team cannot recreate this bug either. Thank you.

Duplicate status (if any):

--