nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Student Id is said to be in the address book when it is not #4838

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

This issue seems to happen when blacklisting is involved.

I added one Sae Byeok with id/e1111112.

Screenshot 2021-11-12 at 4.37.18 PM.png

Then I blacklisted her from orientation camp.

Screenshot 2021-11-12 at 4.37.11 PM.png

Then I edited her id to become id/e1111114

Screenshot 2021-11-12 at 4.40.11 PM.png

Afterwards, when I tried editing her id back to e1111112, it gives this error that e1111112 already exists.

Screenshot 2021-11-12 at 4.40.28 PM.png

However there is no student with that id in the list. The full list I currently have is below.

Screenshot 2021-11-12 at 4.41.08 PM.png

Screenshot 2021-11-12 at 4.41.29 PM.png

Screenshot 2021-11-12 at 4.41.36 PM.png

Screenshot 2021-11-12 at 4.41.44 PM.png

Screenshot 2021-11-12 at 4.41.55 PM.png

This prevents me from adding certain ids after editing, especially if I added a student id wrongly at first.


[original: nus-cs2103-AY2122S1/pe-interim#4807] [original labels: type.FunctionalityBug severity.High]

syoopie commented 2 years ago

Team's Response

Thank you for reporting this issue.

The problem here is occurring due to the way unique students are checked, and not due to an issue with blacklist.

image.png

However, the severity should be low instead of high as it is very unlikely and rare that a student ID would be edited to something different and then edited back to the same one consecutively (editing back and forth). This is because NUS Student Ids are unique and usually unchanging for every student in the first place, hence this is rare and is unlikely to affect normal operations of nustracker.

Duplicate status (if any):

--