nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Blacklisted student is not updated when id changes #4839

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

I blacklisted one Sae Byeok with id/e1111112 from Orientation Camp.

Screenshot 2021-11-12 at 4.37.18 PM.png

Screenshot 2021-11-12 at 4.37.11 PM.png

After editing her id to e/1111114, the id in orientation camp is still not updated.

This may be an intentional implementation, however it causes the wrong student to be blacklisted since students are identified by id.

Screenshot 2021-11-12 at 4.44.44 PM.png


[original: nus-cs2103-AY2122S1/pe-interim#4808] [original labels: type.FunctionalityBug severity.Medium]

Joel-Sung commented 3 years ago

Team's Response

Thank you for reporting this issue.

This is intentional as our blacklist works with student IDs that need not be in the student list as stated in the User Guide. Also, the edit command is supposed to edit the details of an existing student in nustracker, not edit the details of an event's blacklist, as stated in the User Guide. Hence, editing an existing student's student ID should not change the student IDs that were previously blacklisted since they are independent of each other.

Duplicate status (if any):

--