nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Phone number validation too strict #5529

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

The feature does not solve the stated problem of the intended user i.e., the feature is 'incomplete'

Such overzealous input blocking can be considered a type.FeatureFlaw bug.

Screenshot 2021-11-12 at 4.25.37 PM.png

Users might want to save international numbers. The restriction of only 8 digits is too strict, even if you can accept not allowing the + for the country code. This is likely to cause occasional inconvenience (it is not that rare for people to have relatives or next of kin living overseas, especially as Singapore is considered a good place to grow old in and is also particularly cosmopolitan) as the is no convenient workaround for this


[original: nus-cs2103-AY2122S1/pe-interim#5548] [original labels: type.FeatureFlaw severity.Medium]

CraveToCode commented 2 years ago

Team's Response

It is rare for phone numbers to be international, especially in nursing homes were NoK phone numbers are usually local. Even if there is an international phone number, the user can workaround it by using the remark command to add the international phone number as a remark. Hence, we have downgraded the severity to low.

Duplicate status (if any):

--