search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

UG Class diagram composition arrows unnecessary #562

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

composition diamond already reflects direction of composition so the arrows are not required.

[original: nus-cs2103-AY2122S1/pe-interim#541] [original labels: severity.Low type.DocumentationBug]

angkoonhwee commented 2 years ago

Team's Response

The arrows do not affect one's understanding of the diagram and are not wrong according to CS2103T textbook despite not being necessary.

In addition, the following is part of an example of a correct class diagram from Tutorial 8 with composition and arrows together:

image.png

Duplicate status (if any):

--