nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

deleteClass command is case sensitive #5687

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Steps to reproduce bug:

  1. type deleteClass 4e2

Expected output: message saying that class 4e2 has been deleted

Actual output:

image.png

Reason for bug report : similar to before, deleting a class shouldn't be case sensitive as it will become inconvenient for the user if the class name is too long and even one character is entered with the incorrect case while typing the command.


[original: nus-cs2103-AY2122S1/pe-interim#5714] [original labels: type.FeatureFlaw severity.Medium]

Wilfredwongkc commented 2 years ago

Team's Response

Thanks for the issue. We reject this bug for two reasons: Firstly, we have designed the class names to be case sensitive when the class is added into TeachBook, and we would like to use capital and lowercase letters to differentiate two classes. This implies case sensitivity must be required when deleting a class. Secondly, we think it is the correct behaviour for “deleteClass” to require case sensitivity to prevent users from deleting a class (with all the students) carelessly. However, if you really want to consider this as a feature flaw, we think it is of low severity because it is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) a teacher will not use the “deleteClass” frequently 2) under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly 3) if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one.

Duplicate status (if any):

--