nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Non-specific error message displayed for setGrade command #5688

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Steps to reproduce bug:

  1. resetGrade
  2. setGrade A>B>C>D
  3. setGrade A>B>C>D

Expected output: the specified grading system is currently in use (no need to reset)

Actual output:

image.png


[original: nus-cs2103-AY2122S1/pe-interim#5715] [original labels: type.FunctionalityBug severity.Medium]

Wilfredwongkc commented 2 years ago

Team's Response

Thanks for the issue. Firstly, we do not consider this as a non-specific error message because we generally disable the setting any grading system when there is a grading system in use, no matter whether the new grading system users type in is the same as the previous or not. This means the error message is just there to let the user know there is currently a grading system in use, and they should not set a new one before clearing it. Furthermore, if you really want to consider this as a bug, we change the bug type to feature flaw because the specificity of the error message is classified under that category according to the module website. Also, we think it is of low severity because this is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) the current error message may not cause inconvenience to users at all 2) under normal situations, a teacher won’t enter exactly the same grading system as the existing one.

Duplicate status (if any):

--