search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Edit command: can add duplicate entries #5701

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Environment

Windows 11, java version 11.0.9

Steps to reproduce

Use the standard data run command edit 2 /g BlackJack /p 2.74 /dur 10 /loc Genting Casino /date 2021-10-21 12:40

edit 1 /tag drunk

Expected Result

Error message stating entry 1 and 2 are the same

Actual Result

Entries get modified. So now I played 2 games at the same time, same location, same profit, same duration.

Screenshot 2021-11-12 171120.png

[original: nus-cs2103-AY2122S1/pe-interim#5727] [original labels: type.FunctionalityBug severity.Medium]

yzhilong commented 2 years ago

Team's Response

We warn the user that a duplicate game entry with the same game type and date already exists, as seen in this screenshot here

image.png

The screenshot shown in the bug report also has the warning

image.png

We are aware of this issue, but decided to allow duplicate entries because it is possible that the user played games in very close succession (though unlikely). The warning should be sufficient to warn the user that their edit creates a duplicate entry.

Duplicate status (if any):

--