search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Magic number 18...48 in TimetableUi #5711

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

[original: nus-cs2103-AY2122S1/pe-interim#5688] [original labels: severity.VeryLow type.DocumentationBug]

s7u4rt99 commented 2 years ago

Team's Response

We feel that there is no need to justify the numbers for UML diagrams. There was an explanation of how we built it below, and thus it is not needed to explicitly mention it here.

IMAGE 2021-11-13 22:11:52.jpg

This UML diagram from the module website also has magic numbers but it is valid.

Duplicate status (if any):

--