nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Duplicate contacts created using edit command #5713

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Using the edit command I was able to create contacts with same name, email address and birthday. They were differentiated only by contact number. This can lead multiple contacts with the same name, email address and birthday. Same name and birthday is fine, can happen but the same email address along with that means they are the same contacts.

Screenshot 2021-11-12 at 2.04.44 PM.png

Reproduce add n/Alex Yeoh p/12345678 e/email.email@gmail.com a/322, Clementi Ave b/15112020 edit 7 e/alexyeoh@example.com edit 1 b/15112020

expected: Already exists

Actual Creates a new contact


[original: nus-cs2103-AY2122S1/pe-interim#5690] [original labels: type.FunctionalityBug severity.Medium]

leezhixuan commented 2 years ago

Team's Response

Suppose 2 contacts share the same corporate emails, it would make sense for the 2 contacts to have the same email addresses.

As such, it is more likely for people to share email addresses rather than a contact number.

We've also included that in our user guide.

Screenshot 2021-11-14 at 21.18.28.png

Duplicate status (if any):

--