nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Case sensitivity of select command #5728

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Steps to reproduce bug:

  1. type select 4e2

Expected output: details of all students from the class 4E2

Actual output: error message saying class does not exist

image.png

Reason for bug report : Although it is mentioned in the user guide that the select command is case sensitive, for all practical purposes this is overzealous input validation. In a real life scenario one may enter 4e2 in a hurry and be met with an error message saying that the class doesn't exist. This issue becomes worse if the class names are longer.


[original: nus-cs2103-AY2122S1/pe-interim#5707] [original labels: type.FeatureFlaw severity.Medium]

Wilfredwongkc commented 2 years ago

Team's Response

Thanks for the issue. Firstly, our team don’t think this is an overzealous input validation because we have designed the class names to be case sensitive when they are added into TeachBook, and we would like to use capital and lowercase letters to differentiate the two classes. Furthermore, if you really want to consider this as a feature flaw, we think it is of low severity because this is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly 2) if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one.

Duplicate status (if any):

--