search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Error message is not appropriate if you enter a wrong parameter #5747

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Steps to reproduce
show -n Jonas Chow -id E0123456
addassessment -a test -t intermediate

Expected result
Error message telling me that id is a wrong parameter.

Actual result
Error message for name - but my name input is correct.

Screenshots
Screen Shot 2021-11-12 at 4.45.27 PM.png

Screen Shot 2021-11-12 at 5.01.53 PM.png

[original: nus-cs2103-AY2122S1/pe-interim#5776] [original labels: type.FeatureFlaw severity.Medium]

nbvannhi commented 2 years ago

Team's Response

-t is not part of the command format for addassessment. The system does not attempt to detect flags that are not expected in case the user does indeed want to input data which happens to contain the flags.

It's not practical, and in fact overzealous, to detect whether the user is using the wrong flag or specifying invalid names.

for the show command, -id is not a valid flag in our application, so the system assumes that user attempts to input "Jonas Chow -id E0123456" as a name, which is invalid

Duplicate status (if any):

--