nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Incorrect example of test case in DG #5761

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

I think this might be an error in the test case specified in the DG. According to the UG, this should probably result in an invalid command error because both the name and id are specified, not because the name is specified multiple times.

Screen Shot 2021-11-12 at 5.33.51 PM.png

_{[original: nus-cs2103-AY2122S1/pe-interim#5790] [original labels: severity.Low type.DocumentationBug]}

ganhongyao commented 2 years ago

Team's Response

It was not mentioned in the documentation that the error occurred because the name was specified multiple times. Instead, it was mentioned that

Error detail shown in the status message to inform user that the student Hong Fai has been specified more than once.

which is correct, since the student corresponding to Hong Fai was specified more than once with the use of name and ID.

Additionally, both name and id can indeed be used for addgroup as long as they refer to different students

Duplicate status (if any):

--