Open nus-se-bot opened 2 years ago
Hi thanks for the suggestion!
We will consider implementing this feature in the future as this was not our priority since we had more important features to work on. However, this was not in the scope of our application in the current implementation. Our intended implementation of remark is that it merely serves as a short comment for the end user (students) to shortlist tutors that match their requirements.
--
I understand the purpose of having a
remark
functionality for students and tutors. However, by making it open ended, there are certain inaccuracies that can creep into the matching functionality. For instance, let us have a student who wants offline tutoring:Doing
match 4
would match based on the subjects of the student, thus giving this particular tutor in the matched list:However, that tutor does not teach offline classes while this student requires a tutor who does offline classes and therefore, they are not exactly a match for each other. While I understand that making the attribute open ended makes this kind of checking very difficult, it could be an option to make the possible values for the remark attributes limited, or not having it at all, since otherwise the match as shown above is not a valid one.
Considered giving it a severity.Medium, but chose to give severity.Low as it might be considered unlikely to affect normal operations.
[original: nus-cs2103-AY2122S1/pe-interim#5807] [original labels: severity.Low type.FeatureFlaw]