search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Overzealous input validation (for phone number) #5788

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

'It is better to warn rather than to block when inputs are not compliant with the expected format, unless accepting such inputs can hinder the operations of the software'.

In the case of this application, entering an input such as 1234 5678 (HP) 1111-3333 (Office) for phone number attribute will be blocked as it is not within the recommended format. Shown in screenshot below:

image.png

In my opinion, this could be said to hinder the operations of the software, if the application had searching based on phone numbers (as this would be difficult with such an input), but it does not currently have such a functionality. Therefore, the application could instead give a warning and choose to accept the input, making the current feature a bug.

The severity.Medium is chosen as this bug causes an occasional inconvenience to the user but they can continue to use the product.

[original: nus-cs2103-AY2122S1/pe-interim#5819] [original labels: type.FeatureFlaw severity.Medium]

knotstoks commented 2 years ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #5229