search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection bug #5850

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

image.png

I was able to add the same inventory twice. While this might have been an intentional design choice, I don't think it makes practical sense to allow the user to add two same inventories to the list

[original: nus-cs2103-AY2122S1/pe-interim#5828] [original labels: type.FeatureFlaw severity.Medium]

Imranr2 commented 2 years ago

Team's Response

We decided that an ingredient is only considered as a duplicate when the name and unit are the same as mentioned in the user guide.

image.png

This is because the home chef can have different ingredients stocked in different units. For example, tuna can be bought in cans or it can be bought whole.

If the tester means that slice and slices should be regarded as the same unit. It is too challenging to find matches between singular and plural within the timeframe provided for this project.

We are also unclear as to what the tester means by "same inventory". By our definition, the 2 ingredients that the tester added are not duplicates

Duplicate status (if any):

--