search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

No warning message when the edited information is the same as before #5873

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

Steps to reproduce: when the member at index 1 of the displayed list is named "Bernice Yu", and we type command edit -mem/ -i/1 -n/Bernice Yu

Expected: An error message saying "The field value is not edited / same as before"

Actual: No error message is shown; editing is still allowed

image.png

[original: nus-cs2103-AY2122S1/pe-interim#5872] [original labels: type.FeatureFlaw severity.VeryLow]

HolmesJJ commented 2 years ago

Team's Response

Thank you for your effort and time. However it is not a bug.

  1. It will not cause any performance problem even if a user just updates the field with the same content. Hence, we believe that a user can definitely update the field with the same content since it will not have any negative effect on the program or cause any security issue. It is also unreasonable to show an "error message" to the user for this.

  2. Excessive verification may even cause unnecessary bugs.

Therefore, we allow ezFoodie to accept edits with same content.

Hope this clarify your doubt.

Duplicate status (if any):

--