search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Recursive nature of Chaining commands is not documented in DG #939

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

the command list && list && list seems to parse the left of the first &&, the right side of &&, of which the right side will also accept commands with &&, this behaviour should be documented using reference frames.

Screenshot from 2021-11-12 17-19-22.png

For reference (can be found in cs2103 official website as well)

Screenshot from 2021-11-12 17-22-17.png

[original: nus-cs2103-AY2122S1/pe-interim#973] [original labels: severity.Low type.DocumentationBug]

nzixuan commented 2 years ago

Team's Response

The recursive nature of chain command is captured by the fact that ChainCommand in fact a Command as well and is parsed by the AddressBookParser to be part of :Command in another ChainCommand. Hence there is no bug in the sequence diagram.

Duplicate status (if any):

--