nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Reminder window can display applications where interview date and time is past #1046

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

The reminder window seems to not display applications where the interview date and time is before the current time. E.g. if it is 16 April 3pm right now, it is designed to not show applications where the interview date and time is 16 April 2pm.

However, if the application is left running over a long period of time, it is possible where the reminder window can still display applications where the interview is already over.

Steps to reproduce:

1) Suppose the current date and time is 16 April 2022, 2.52pm.

2) Enter edit 1 idt/16-04-2022 14:53. (i.e. set the first application's interview time to be 1 min from now)

Expected behaviour:

Actual behaviour:

Screenshot:

image.png

Note the current date and time, and the date and time of Application 1.


[original: nus-cs2103-AY2122S2/pe-interim#872] [original labels: severity.Low type.FeatureFlaw]

lchokhoe commented 2 years ago

Team's Response

Reject this Bug.

The intended usage of the reminder window is for users to get a reminder on command. The reason we have the reminder window be opened on the startup of our application is to save the users time keying in the reminder command and also avoid a situation where the user forgets to remind himself or herself.

The reminder window was not implemented to provide live updates either. It will not update just because the local time on the user's device has ticked over.

The use case proposed in this issue is an example of "extreme user behaviour". While we do not expect users to always close the reminder window that gets opened on startup, we also do not expect users to refer to the same instance of the reminder window after hours have lapsed and then accept that an interview that was supposed to happen hours ago still is happening. If accepted as a bug, it would be more appropriate to consider this a Low Severity Functionality Bug in our opinion.

Duplicate status (if any):

--