search

nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Illegal Argument Exception not handled for invalid fields #1126

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

When entering an invalid value for certain fields (completion time and serving size) and clicking entering, nothing happens in the app itself. No error message is shown prompting the user about that error. In the terminal, I can see that a java.lang.IllegalArgumentException has been thrown. Without looking at the terminal, I will not know what happened. This applies for both adding and editing.

Completion time more than 525600: image.png

Serving size more than 2000: image.png

[original: nus-cs2103-AY2122S2/pe-interim#960] [original labels: type.FunctionalityBug severity.High]

aidanaden commented 2 years ago

Team's Response

When reproduced, although no error feedback is given, the error does not cause the application to break and users can continue using the application.

According to CS2103T docs:

severity.High : A flaw that affects most users and causes major problems for users. i.e., only problems that make the product almost unusable for most users should have this label.

We don't believe that this error causes any major problems for users - hence we believe a more suitable severity level would be "Low":

severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

Duplicate status (if any):

--