search

nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Duplicate patron #1470

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Error message when adding in patrons is not explicit in the reason why its considered a duplicate.

Replicating bug: patron add n/Harper Lee s/A0988773M p/91437496 e/harperlee@u.nus.eduuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu patron add n/Harper Lee s/A0988773M p/91437496 e/harperlee@u.nus.eduuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu

image.png

[original: nus-cs2103-AY2122S2/pe-interim#1469] [original labels: severity.Medium type.FeatureFlaw]

bingsen0806 commented 2 years ago

Team's Response

Thank you for reporting this issue.

image.png

As per the module website, unspecific error messages is at most low severity.

This issue can be solved by adding new error messages for same email, same name and same if respectively in our Message class, and writing a function for printing one of these 3 messages whenever the patron is considered be the same as an existing patron based on isSamePatron() function.

Duplicate status (if any):

--